[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [PATCH 1/4] tests/pxe-test: Remove unnecessary special ca

From: Thomas Huth
Subject: Re: [Qemu-ppc] [PATCH 1/4] tests/pxe-test: Remove unnecessary special case test functions
Date: Fri, 15 Dec 2017 11:54:25 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0

On 15.12.2017 11:16, David Gibson wrote:
> All of the x86 and some of the other test cases here use a common test
> function, test_pxe_ipv4(), but one ppc and one s390 test use different
> functions.
> In the s390 case, this is completely pointless, the right parameter to
> test_pxe_ipv4() will already do exactly the right thing.  For the
> spapr-vlan case there's a slight difference - it will use IPv6 instead of
> IPv4.
> But testing just one case with IPv6 (and NOT IPv4) is rather haphazard.
> Change everything to use the common test function, until we have a better
> way of testing IPv6 across the board.
> Signed-off-by: David Gibson <address@hidden>
> ---
>  tests/pxe-test.c | 15 +++------------
>  1 file changed, 3 insertions(+), 12 deletions(-)

Reviewed-by: Thomas Huth <address@hidden>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]