[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [PATCH] vga: make stdvga the global default

From: Eduardo Habkost
Subject: Re: [Qemu-ppc] [PATCH] vga: make stdvga the global default
Date: Thu, 5 Jul 2018 13:31:08 -0300
User-agent: Mutt/1.9.2 (2017-12-15)

On Thu, Jul 05, 2018 at 05:24:09PM +0100, Mark Cave-Ayland wrote:
> On 05/07/18 14:12, Eduardo Habkost wrote:
> > > I also checked the code, default values are used also for other fields in
> > > that struct (e.g., default_cpus). If default values are considered 
> > > fragile,
> > > they must be changed as well in the middle term. However, given a solid
> > > documentation (which is currently missing for these fields) I still think
> > > that default values are acceptable.
> > > 
> > > Note that there seems also be the possibility to set != NULL default 
> > > values
> > > in the machine_class_init() function.
> > 
> > I don't mind if the default value is defined at
> > machine_class_init() or main().  What bothers me is a default
> > value that depends on vga_interface_available(), because it can
> > be easily broken by a build config change (as demonstrated by the
> > bug fixed by this patch).
> I've already sent David a for-3.0 patch to set stdvga for the PPC Mac
> machines, but should I also do the same for PReP too?
> Is it also worth explicitly adding this for sun4u? And what about
> non-ISA/PCI cards such as sun4m's TCX/CG3?

I think it's worth it.  Having fewer machines with
default_display==NULL sounds like a good idea to me.

Having zero machines with default_display==NULL (so we can
finally delete the vga_interface_available() checks on main())
would be even better.

This is not urgent, though (unless there we plan to change
CONFIG_VGA_* on default-configs again in 3.0).


reply via email to

[Prev in Thread] Current Thread [Next in Thread]