Re: [PATCH v3 7/7] target/ppc: isolated cpu init from translation logic

[Richard Henderson]

On 4/30/21 12:35 PM, Bruno Larsen (billionai) wrote:
> +++ b/target/ppc/cpu_init.c
> @@ -18,6 +18,7 @@
>    * License along with this library; if not, see<http://www.gnu.org/licenses/>.
>    */
>   
> +#include "qemu/osdep.h"
>   #include "disas/dis-asm.h"
>   #include "exec/gdbstub.h"
>   #include "kvm_ppc.h"
> @@ -42,7 +43,10 @@
>   #include "fpu/softfloat.h"
>   #include "qapi/qapi-commands-machine-target.h"
>   
> +#include "helper_regs.h"
> +#include "internal.h"
>   #include "spr_tcg.h"

You need "exec/helper-proto.h" until you deal with helper_mtvscr().

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~