[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC 10/15] target/riscv: rvb: rotate (left/right)
|
From: |
Richard Henderson |
|
Subject: |
Re: [RFC 10/15] target/riscv: rvb: rotate (left/right) |
|
Date: |
Thu, 19 Nov 2020 13:06:54 -0800 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 11/18/20 12:29 AM, frank.chang@sifive.com wrote:
> +static bool trans_rori(DisasContext *ctx, arg_rori *a)
> +{
> + REQUIRE_EXT(ctx, RVB);
> +
> + if (a->shamt >= TARGET_LONG_BITS) {
> + return false;
> + }
> +
> + return gen_arith_shamt_tl(ctx, a, &tcg_gen_rotr_tl);
> +}
We most definitely want to use tcg_gen_rotri_tl here, as we have special
expansions of constant shifts for hosts without rotate (e.g. riscv64g ;-).
Otherwise, this patch should be included in the shift cleanup discussed
upthread.
r~
- Re: [RFC 06/15] target/riscv: rvb: min/max instructions, (continued)
- [RFC 07/15] target/riscv: rvb: sign-extend instructions, frank . chang, 2020/11/18
- [RFC 08/15] target/riscv: rvb: single-bit instructions, frank . chang, 2020/11/18
- [RFC 09/15] target/riscv: rvb: shift ones, frank . chang, 2020/11/18
- [RFC 10/15] target/riscv: rvb: rotate (left/right), frank . chang, 2020/11/18
- Re: [RFC 10/15] target/riscv: rvb: rotate (left/right),
Richard Henderson <=
- [RFC 11/15] target/riscv: rvb: generalized reverse, frank . chang, 2020/11/18
- [RFC 12/15] target/riscv: rvb: generalized or-combine, frank . chang, 2020/11/18
- [RFC 13/15] target/riscv: rvb: address calculation, frank . chang, 2020/11/18
- [RFC 14/15] target/riscv: rvb: add/sub with postfix zero-extend, frank . chang, 2020/11/18
- [RFC 15/15] target/riscv: rvb: support and turn on B-extension from command line, frank . chang, 2020/11/18