|
From: | Richard Henderson |
Subject: | Re: [PATCH v5 01/22] target/riscv: Adjust pmpcfg access with mxl |
Date: | Fri, 26 Nov 2021 12:19:54 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 |
On 11/25/21 8:39 AM, LIU Zhiwei wrote:
+static bool check_pmp_reg_index(CPURISCVState *env, uint32_t reg_index) +{ + if ((reg_index & 1) && (riscv_cpu_mxl(env) == MXL_RV64)) {
Let's make this != MXL_RV32. I suppose real RV128 will extend this restriction to mod 4, but that is not yet documented.
Otherwise, Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
[Prev in Thread] | Current Thread | [Next in Thread] |