[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 15/18] target/riscv: Allow debugger to access sstc CSRs
From: |
Bin Meng |
Subject: |
[PATCH 15/18] target/riscv: Allow debugger to access sstc CSRs |
Date: |
Tue, 14 Feb 2023 12:12:48 +0800 |
At present with a debugger attached sstc CSRs can only be accssed
when CPU is in M-mode, or configured correctly.
Fix it by adjusting their predicate() routine logic so that the
static config check comes before the run-time check, as well as
addding a debugger check.
Signed-off-by: Bin Meng <bmeng@tinylab.org>
---
target/riscv/csr.c | 19 ++++++++++++++-----
1 file changed, 14 insertions(+), 5 deletions(-)
diff --git a/target/riscv/csr.c b/target/riscv/csr.c
index d6bcb7f275..c6a7745cb2 100644
--- a/target/riscv/csr.c
+++ b/target/riscv/csr.c
@@ -951,6 +951,19 @@ static RISCVException sstc(CPURISCVState *env, int csrno)
return RISCV_EXCP_ILLEGAL_INST;
}
+ if ((csrno == CSR_VSTIMECMP) || (csrno == CSR_VSTIMECMPH)) {
+ hmode_check = true;
+ }
+
+ RISCVException ret = hmode_check ? hmode(env, csrno) : smode(env, csrno);
+ if (ret != RISCV_EXCP_NONE) {
+ return ret;
+ }
+
+ if (env->debugger) {
+ return RISCV_EXCP_NONE;
+ }
+
if (env->priv == PRV_M) {
return RISCV_EXCP_NONE;
}
@@ -971,11 +984,7 @@ static RISCVException sstc(CPURISCVState *env, int csrno)
}
}
- if ((csrno == CSR_VSTIMECMP) || (csrno == CSR_VSTIMECMPH)) {
- hmode_check = true;
- }
-
- return hmode_check ? hmode(env, csrno) : smode(env, csrno);
+ return RISCV_EXCP_NONE;
}
static RISCVException sstc_32(CPURISCVState *env, int csrno)
--
2.25.1
- Re: [PATCH 00/18] target/riscv: Various fixes to gdbstub and CSR access, (continued)
- Re: [PATCH 00/18] target/riscv: Various fixes to gdbstub and CSR access, Daniel Henrique Barboza, 2023/02/13
- [PATCH 12/18] target/riscv: Allow debugger to access user timer and counter CSRs, Bin Meng, 2023/02/13
- [PATCH 13/18] target/riscv: Allow debugger to access seed CSR, Bin Meng, 2023/02/13
- [PATCH 14/18] target/riscv: Allow debugger to access {h, s}stateen CSRs, Bin Meng, 2023/02/13
- [PATCH 15/18] target/riscv: Allow debugger to access sstc CSRs,
Bin Meng <=
- [PATCH 16/18] target/riscv: Drop priv level check in mseccfg predicate(), Bin Meng, 2023/02/13
- [PATCH 17/18] target/riscv: Group all predicate() routines together, Bin Meng, 2023/02/13
- [PATCH 18/18] target/riscv: Move configuration check to envcfg CSRs predicate(), Bin Meng, 2023/02/14