[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [qemu-s390x] [PATCH v2 1/2] make: move generated headers to qemu-bui

From: Eric Blake
Subject: Re: [qemu-s390x] [PATCH v2 1/2] make: move generated headers to qemu-build/
Date: Thu, 22 Mar 2018 14:42:55 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0

On 03/22/2018 02:27 PM, Michael S. Tsirkin wrote:
Make sure all generated files go into qemu-build subdirectory.
We can then include them like this:
  #include "qemu-build/trace.h"

This serves two purposes:
- make it easy to detect which files are in the source
   directory (a bit more work for writers, easier for readers)
- reduce chances of conflicts with possible stale files in source
   directory (which could be left over from e.g. old patches, etc)

This patch needs to be merged with patch 2  of series updating all
files: sending it separately to avoid spamming the list.

Signed-off-by: Michael S. Tsirkin <address@hidden>

+++ b/Makefile
@@ -89,102 +89,102 @@ endif
include $(SRC_PATH)/rules.mak -GENERATED_FILES = qemu-version.h config-host.h qemu-options.def
-GENERATED_FILES += qapi/qapi-builtin-types.h qapi/qapi-builtin-types.c

Uggh - I really need to follow up on my threat to make smarter use of make variables and string manipulation to cut down on the boilerplate involved here. Sadly, I'm not convinced that doing so is a 2.12 bugfix priority, so it isn't at the top of my work queue.

Overall, the patch is an interesting idea. I'm still not 100% sold on it (as you say, it's now slightly more work for writers), but I'm not coming up with any solid reasons why it should not be applied (at least, for 2.13 - doing it during freeze for 2.12 is a bit harder to justify).

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]