[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [qemu-s390x] [PATCH v2 1/2] make: move generated headers to qemu-bui
Daniel P . Berrangé
Re: [qemu-s390x] [PATCH v2 1/2] make: move generated headers to qemu-build/
Fri, 23 Mar 2018 10:22:27 +0000
On Thu, Mar 22, 2018 at 09:27:55PM +0200, Michael S. Tsirkin wrote:
> Make sure all generated files go into qemu-build subdirectory.
> We can then include them like this:
> #include "qemu-build/trace.h"
> This serves two purposes:
> - make it easy to detect which files are in the source
> directory (a bit more work for writers, easier for readers)
> - reduce chances of conflicts with possible stale files in source
> directory (which could be left over from e.g. old patches, etc)
If people care about this, then they can just be doing a build
with srcdir != builddir config. If people are using srcdir == builddir
then they likely *want* all the generated files in their srcdir.
IMHO it would be valid for us to consider if we could just mandate
srcdir != builddir, but if people object to such a proposal, then I
don't think we should arbitrarily move all generated source files
in this way, as that's effectively the same thing forced onto devs.
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|