[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [qemu-s390x] [PATCH] hw/s390x: Fix bad mask in time2tod()

From: Thomas Huth
Subject: Re: [qemu-s390x] [PATCH] hw/s390x: Fix bad mask in time2tod()
Date: Fri, 14 Dec 2018 14:23:35 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1

On 2018-12-14 14:15, Christian Borntraeger wrote:
> On 14.12.2018 14:08, Thomas Huth wrote:
>> The time2tod() function tries to deal with the 9 uppermost bits in the
>> time value, but uses the wrong mask for this: 0xff80000000000000 should
>> be used instead of 0xff10000000000000 here.
>> Fixes: 14055ce53c2d901d826ffad7fb7d6bb8ab46bdfd
> Can you alsways have commit id and subject
> like
> Fixes: 14055ce53c2d ("s390x/tcg: avoid overflows in time2tod/tod2time")

In https://wiki.qemu.org/Contribute/SubmitAPatch we currently have:

 Fixes: <full-SHA-commit-id>

... and the full commit ID is sometimes very useful for downstream, so
I'd rather avoid to abbreviate that here. But I can try to remember to
put the title of the patch in another spot of the description, too.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]