[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [qemu-s390x] [Qemu-devel] [PATCH v5 11/15] memory: Single byte swap

From: Richard Henderson
Subject: Re: [qemu-s390x] [Qemu-devel] [PATCH v5 11/15] memory: Single byte swap along the I/O path
Date: Fri, 26 Jul 2019 07:29:15 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0

On 7/26/19 2:26 AM, Paolo Bonzini wrote:
> On 26/07/19 08:47, address@hidden wrote:
>> +        op = SIZE_MEMOP(size);
>> +        if (need_bswap(big_endian)) {
>> +            op ^= MO_BSWAP;
>> +        }
> And this has the same issue as the first version.  It should be
>       op = SIZE_MEMOP(size) | (big_endian ? MO_BE : MO_LE);
> and everything should work.  If it doesn't (and indeed it doesn't :)) it
> means you have bugs somewhere else.

As I mentioned against patch 9, which also touches this area, it should be
using the MemOp that is already passed in to this function instead of building
a new one from scratch.

But, yes, any failure in that would mean bugs somewhere else.  ;-)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]