[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 1/5] target/s390x: Fix SLDA sign bit index
From: |
Ilya Leoshkevich |
Subject: |
[PATCH v4 1/5] target/s390x: Fix SLDA sign bit index |
Date: |
Wed, 12 Jan 2022 17:50:12 +0100 |
SLDA operates on 64-bit values, so its sign bit index should be 63,
not 31.
Fixes: a79ba3398a0a ("target-s390: Convert SHIFT DOUBLE")
Reported-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
---
target/s390x/tcg/insn-data.def | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/s390x/tcg/insn-data.def b/target/s390x/tcg/insn-data.def
index f0af458aee..90c753068c 100644
--- a/target/s390x/tcg/insn-data.def
+++ b/target/s390x/tcg/insn-data.def
@@ -800,7 +800,7 @@
C(0xebde, SRLK, RSY_a, DO, r3_32u, sh32, new, r1_32, srl, 0)
C(0xeb0c, SRLG, RSY_a, Z, r3_o, sh64, r1, 0, srl, 0)
/* SHIFT LEFT DOUBLE */
- D(0x8f00, SLDA, RS_a, Z, r1_D32, sh64, new, r1_D32, sla, 0, 31)
+ D(0x8f00, SLDA, RS_a, Z, r1_D32, sh64, new, r1_D32, sla, 0, 63)
/* SHIFT LEFT DOUBLE LOGICAL */
C(0x8d00, SLDL, RS_a, Z, r1_D32, sh64, new, r1_D32, sll, 0)
/* SHIFT RIGHT DOUBLE */
--
2.31.1
- [PATCH v4 0/5] target/s390x: Fix shift instructions, Ilya Leoshkevich, 2022/01/12
- [PATCH v4 5/5] tests/tcg/s390x: Test shift instructions, Ilya Leoshkevich, 2022/01/12
- [PATCH v4 3/5] target/s390x: Fix cc_calc_sla_64() missing overflows, Ilya Leoshkevich, 2022/01/12
- [PATCH v4 1/5] target/s390x: Fix SLDA sign bit index,
Ilya Leoshkevich <=
- [PATCH v4 2/5] target/s390x: Fix SRDA CC calculation, Ilya Leoshkevich, 2022/01/12
- [PATCH v4 4/5] target/s390x: Fix shifting 32-bit values for more than 31 bits, Ilya Leoshkevich, 2022/01/12
- Re: [PATCH v4 0/5] target/s390x: Fix shift instructions, Thomas Huth, 2022/01/18