[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 4/5] target/s390x: Fix shifting 32-bit values for more tha
|
From: |
David Hildenbrand |
|
Subject: |
Re: [PATCH v4 4/5] target/s390x: Fix shifting 32-bit values for more than 31 bits |
|
Date: |
Thu, 13 Jan 2022 09:23:25 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 |
On 12.01.22 17:50, Ilya Leoshkevich wrote:
> According to PoP, both 32- and 64-bit shifts use lowest 6 address
> bits. The current code special-cases 32-bit shifts to use only 5 bits,
> which is not correct. For example, shifting by 32 bits currently
> preserves the initial value, however, it's supposed zero it out
> instead.
>
> Fix by merging sh32 and sh64 and adapting CC calculation to shift
> values greater than 31.
>
> Fixes: cbe24bfa91d2 ("target-s390: Convert SHIFT, ROTATE SINGLE")
> Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
> ---
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
- [PATCH v4 0/5] target/s390x: Fix shift instructions, Ilya Leoshkevich, 2022/01/12
- [PATCH v4 5/5] tests/tcg/s390x: Test shift instructions, Ilya Leoshkevich, 2022/01/12
- [PATCH v4 3/5] target/s390x: Fix cc_calc_sla_64() missing overflows, Ilya Leoshkevich, 2022/01/12
- [PATCH v4 1/5] target/s390x: Fix SLDA sign bit index, Ilya Leoshkevich, 2022/01/12
- [PATCH v4 2/5] target/s390x: Fix SRDA CC calculation, Ilya Leoshkevich, 2022/01/12
- [PATCH v4 4/5] target/s390x: Fix shifting 32-bit values for more than 31 bits, Ilya Leoshkevich, 2022/01/12
- Re: [PATCH v4 4/5] target/s390x: Fix shifting 32-bit values for more than 31 bits,
David Hildenbrand <=
- Re: [PATCH v4 0/5] target/s390x: Fix shift instructions, Thomas Huth, 2022/01/18