[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-stable] [Qemu-devel] [PATCH 0/3] contrib/rdmacm-mux: fix clang

From: Marcel Apfelbaum
Subject: Re: [Qemu-stable] [Qemu-devel] [PATCH 0/3] contrib/rdmacm-mux: fix clang compilation
Date: Mon, 14 Jan 2019 23:26:02 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1

Hi Cornelia,

On 1/14/19 1:42 PM, Cornelia Huck wrote:
On Sat, 12 Jan 2019 17:02:22 +0200
Marcel Apfelbaum <address@hidden> wrote:

Fix Commit a5d2f6f877 (contrib/rdmacm-mux: Add implementation
                        of RDMA User MAD multiplexer).

The above commit introduces a new contrib target, adding a global dependency
to libumad library in case pvrdma configuration option is enabled.
Clang forbids it:
     clang-6.0: error: -libumad: 'linker' input unused

Fix by limiting the scope to the rdmacm-mux target itself.
Fix related clang errors while at it.

Marcel Apfelbaum (3):
   contrib/rdmacm-mux: remove Wno-format-truncation flag
   hw/rdma: modify struct initialization
   contrib/rdmacm-mux: fix clang compilation

  Makefile                         |  2 ++
  contrib/rdmacm-mux/Makefile.objs |  1 -
  contrib/rdmacm-mux/main.c        | 18 +++++++++++++-----
  hw/rdma/rdma_backend.c           | 16 ++++++++++++----
  4 files changed, 27 insertions(+), 10 deletions(-)

This fixes building on x86 with clang 6 for me. On s390x with clang 7,
I run into further problems when building the s390-ccw bios (the
maintainers are aware of that), but the rdma-related errors are gone.

Tested-by: Cornelia Huck <address@hidden>


reply via email to

[Prev in Thread] Current Thread [Next in Thread]