[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH] Makefile: Fix parallel building after a clean

From: Michael Roth
Subject: Re: [Qemu-trivial] [PATCH] Makefile: Fix parallel building after a clean tree
Date: Tue, 26 Jul 2011 11:36:46 -0500
User-agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:5.0) Gecko/20110624 Thunderbird/5.0

On 07/26/2011 09:33 AM, Stefan Berger wrote:
This patch fixes a compilation error when building qemu after 'make clean'
by parallel building using 'make -j6' for example. A dependency seems to be 

   GEN   qemu-options.def
   GEN   trace.h
   GEN   qapi-generated/qga-qapi-types.h
   GEN   qapi-generated/qga-qapi-visit.h
   GEN   qapi-generated/qga-qmp-marshal.c
   CC    qga/guest-agent-command-state.o
   CC    qga/guest-agent-commands.o
   GEN   trace.c
   GEN   qemu-img-cmds.h
cc1: error: qapi-generated: No such file or directory [-Werror]
cc1: all warnings being treated as errors

Signed-off-by: Stefan Berger<address@hidden>

  Makefile |    2 ++
  1 file changed, 2 insertions(+)

Index: qemu-git/Makefile
--- qemu-git.orig/Makefile
+++ qemu-git/Makefile
@@ -192,6 +192,8 @@ test-qmp-commands.o: $(addprefix $(qapi-
  test-qmp-commands: test-qmp-commands.o qfloat.o qint.o qdict.o qstring.o 
qlist.o qbool.o $(qapi-obj-y) error.o osdep.o qemu-malloc.o $(oslib-obj-y) 
qjson.o json-streamer.o json-lexer.o json-parser.o qerror.o qemu-error.o 
qemu-tool.o $(qapi-dir)/test-qapi-visit.o $(qapi-dir)/test-qapi-types.o 
$(qapi-dir)/test-qmp-marshal.o module.o

  QGALIB=qga/guest-agent-command-state.o qga/guest-agent-commands.o
+$(QGALIB): qemu-ga.o

  qemu-ga.o: $(addprefix $(qapi-dir)/, qga-qapi-types.c qga-qapi-types.h 
qga-qapi-visit.c qga-qmp-marshal.c) $(qapi-obj-y)
  qemu-ga$(EXESUF): qemu-ga.o $(QGALIB) qemu-tool.o qemu-error.o error.o 
$(oslib-obj-y) $(trace-obj-y) $(block-obj-y) $(qobject-obj-y) $(version-obj-y) 
$(qapi-obj-y) qemu-timer-common.o qemu-sockets.o module.o qapi/qmp-dispatch.o 
qapi/qmp-registry.o $(qapi-dir)/qga-qapi-visit.o $(qapi-dir)/qga-qapi-types.o 

Hi Stefan,

Thanks for catching this. It seems to do the trick for me up until make -j10, where a missing dependency on $(GENERATED_HEADERS) becomes an issue. I'll have a patch I'll send shortly.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]