[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH] qdev property: cleanup

From: Cao jin
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] qdev property: cleanup
Date: Tue, 12 Apr 2016 20:49:04 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0

On 04/12/2016 04:20 PM, Markus Armbruster wrote:

Here's my try rewording the comment (sticking to GTK-Doc conventions
even though I dislike them):

  * @qdev_property_add_static:
  * @dev: Device to add the property to
  * @prop: The qdev property definition
  * @err: location to store error information
  * Add a static QOM property to @dev for qdev property @prop.
  * On error, store error in @errp.

Paolo, is it correct?

Cao jin, is it an improvement?

Yes, better, save the unnecessary pains to analyse the property type for me:)

Yours Sincerely,

Cao jin

reply via email to

[Prev in Thread] Current Thread [Next in Thread]