[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH] qdev property: cleanup

From: Cao jin
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] qdev property: cleanup
Date: Fri, 15 Apr 2016 19:15:17 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0

On 04/15/2016 06:06 PM, Paolo Bonzini wrote:

Here's my try rewording the comment (sticking to GTK-Doc conventions
even though I dislike them):

  * @qdev_property_add_static:
  * @dev: Device to add the property to
  * @prop: The qdev property definition
  * @err: location to store error information
  * Add a static QOM property to @dev for qdev property @prop.
  * On error, store error in @errp.

Paolo, is it correct?

Yes, it is.  You can add also "The type of the QOM property is derived
from prop->info", which is what Cao Jin really wanted to convey in his


Thanks Paolo for your explanation, much useful info for me:)

I will collect Markus`s rewording and your suggestion into v2 later.

Yours Sincerely,

Cao jin

reply via email to

[Prev in Thread] Current Thread [Next in Thread]