[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Quilt-dev] [patch] verbose error message when the serie file does n

From: Martin Quinson
Subject: Re: [Quilt-dev] [patch] verbose error message when the serie file does not exist
Date: Mon, 23 Mar 2020 23:14:09 +0100

On Mon, Mar 23, 2020 at 01:28:33PM +1100, Martin Panter wrote:
> Aha! so that's where this funny error message comes from on Debian.
> Can you remove the \n garbage at the end of it? The "echo" command
> adds its own newline at the end of the message anyway.
> $ quilt series -v
> No series file found\n

Ok, I'm stupid. What a shame. Here is a fixed version, using printf
instead of echo. Many thanks for the review.

Bye, Mt.

Description: verbose error message when the series file does not exist
 patchfns.in(cat_series): Displays an error message when the $SERIES
 file does not exist, and when run in verbose mode.
Bug-Debian: https://bugs.debian.org/369908
Upstream-status: submitted 

 quilt/scripts/patchfns.in |    3 +++
 1 file changed, 3 insertions(+)

Index: b/quilt/scripts/patchfns.in
--- a/quilt/scripts/patchfns.in
+++ b/quilt/scripts/patchfns.in
@@ -358,6 +358,9 @@ cat_series()
                sed -e '/^#/d' -e 's/^[ '$'\t'']*//' \
                    -e 's/[ '$'\t''].*//' -e '/^$/d' "$SERIES"
+               if [ "$opt_verbose" ]; then
+                       printf $"No series file found\n" >&2
+               fi
                return 1

Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]