Re: [RP] Ratpoison comments from a new user

[Gergely Nagy]

Greetings!

> 
> I'm using the cvs version (I checked it out yesterday) and one minor
> bug that I thought I'd mention is that when ratpoison starts up, it
> tells you to use C-t ? for help, even if the prefix key has been
> changed.  Not that big of a deal, though.

Attached is a patch that should fix this.

> Also, the info file is slightly out of date.  
> For escape, it still says to use the ^b notation, instead of C-b.
> It also doesn't mention the rudeness command, or select -.
>

Hm. I pondered about that too a few days ago. If I have time, and
someone doesn't update those faster, I'll probably do it in the weekend.

> But the bottom line is that ratpoison, as is, is the best (in my
> opinion) wm that I've come across.

I have to agree with that. I feel so clean and productive when using
something as elegant as ratpoison.

-- 
Gergely Nagy \ mhp/|8]

2001-09-01  Gergely Nagy  <address@hidden>

            * src/main.c (main): use the correct prefix key in the
            greeting message
            * src/messages.h [MESSAGE_WELCOME]: use %s instead of
            hard-coded C-t

diff -urdp ratpoison.orig/src/main.c ratpoison/src/main.c
--- ratpoison.orig/src/main.c   Thu Aug 23 20:51:12 2001
+++ ratpoison/src/main.c        Fri Aug 31 23:52:59 2001
@@ -317,6 +317,7 @@ main (int argc, char *argv[])
   int do_restart = 0;
   int do_command = 0;
   char *command = NULL;
+  char *prefix_sym, *welcome_message;
 
   myargv = argv;
 
@@ -430,7 +431,13 @@ main (int argc, char *argv[])
   read_startup_files ();
 
   /* Indicate to the user that ratpoison has booted */
-  message (MESSAGE_WELCOME);
+  prefix_sym = keysym_to_string (prefix_key.sym, prefix_key.state);
+  welcome_message = (char *)xmalloc (strlen (prefix_sym) + strlen 
(MESSAGE_WELCOME) + 10);
+  snprintf (welcome_message, strlen (prefix_sym) + strlen (MESSAGE_WELCOME) + 
9,
+           MESSAGE_WELCOME, prefix_sym);
+  message (welcome_message);
+  free (prefix_sym);
+  free (welcome_message);
   
   handle_events ();
 
diff -urdp ratpoison.orig/src/messages.h ratpoison/src/messages.h
--- ratpoison.orig/src/messages.h       Fri Aug 31 20:18:32 2001
+++ ratpoison/src/messages.h    Fri Aug 31 23:53:06 2001
@@ -42,6 +42,6 @@
 #define MESSAGE_PROMPT_SWITCH_WM " Switch to wm: "
 #define MESSAGE_PROMPT_XTERM_COMMAND MESSAGE_PROMPT_SHELL_COMMAND TERM_PROG " 
-e "
 
-#define MESSAGE_WELCOME " Welcome to ratpoison! Hit C-t ? for help. "
+#define MESSAGE_WELCOME " Welcome to ratpoison! Hit %s ? for help. "
 
 #endif /* ! _RATPOISON_MESSAGES_H */

pgpBDqY9HUzhA.pgp
Description: PGP signature