Re: [RP] [PATCH] treat windows with _NET_WM_PID when created and set later thesame

[Ted Walther]

Bernhard, another cool thing we could do with _NET_WM_PID, I'd like to
launch a program and specify ahead of time what title to force onto it.
Then the "select firefox" trick would work.  Think you could whip up a
quick patch to do that?

Also, Bern, I'm going to do a Debian release of the ratpoison CVS
version soon; do you have any patches that have not yet been
incorporated?

Shawn, can you just release 1.4.0 or go to beta5?  It looks like there
have definitely been improvements since beta4.

Ted

On Wed, Mar 15, 2006 at 07:06:20PM +0100, Bernhard R. Link wrote:
> The attached patch makes event.c's handling of _NET_WM_PID behave
> like window.c's, namely using child_info->window_mapped.
>
> Hochachtungsvoll,
>         Bernhard R. Link

> Index: src/events.c
> ===================================================================
> RCS file: /cvsroot/ratpoison/ratpoison/src/events.c,v
> retrieving revision 1.127
> diff -u -p -r1.127 events.c
> --- src/events.c        15 Mar 2006 07:25:04 -0000      1.127
> +++ src/events.c        15 Mar 2006 18:03:19 -0000
> @@ -603,12 +603,14 @@ property_notify (XEvent *ev)
>
>           PRINT_DEBUG (("updating _NET_WM_PID\n"));
>           child_info = get_child_info(win->w);
> -	  if (child_info) 
> +	  if (child_info && !child_info->window_mapped) 
> 	    {
>               if (child_info->frame)
>                 {
>                   PRINT_DEBUG (("frame=%p\n", child_info->frame));
>                   win->intended_frame_number = child_info->frame->number;
> +                 /* Only map the first window in the launch frame. */
> +                 child_info->window_mapped = 1;
>                 }
>               /* TODO: also adopt group information? */
>             }

> _______________________________________________
> Ratpoison-devel mailing list
> address@hidden
> http://lists.nongnu.org/mailman/listinfo/ratpoison-devel


--
         It's not true unless it makes you laugh,                           
    but you don't understand it until it makes you weep.

Eukleia: Ted Walther
Address: 5690 Pioneer Ave, Burnaby, BC  V5H2X6 (Canada)
Contact: 604-430-4973

signature.asc
Description: Digital signature