[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: tests: test -i/--inplace with backup suffix option

From: Jim Meyering
Subject: Re: tests: test -i/--inplace with backup suffix option
Date: Wed, 1 Jun 2016 08:28:08 -0700

On Wed, Jun 1, 2016 at 8:14 AM, Jim Meyering <address@hidden> wrote:
> On Tue, May 31, 2016 at 10:26 PM, Assaf Gordon <address@hidden> wrote:
>> Hello,
>>> Instead, I propose the attached patch (intended to be applied before
>>> your test additions), that adds the envvar-check file, as used in grep
>>> and coreutils, along with adjustments
>> Attached improved (and expanded) tests, adjusted to the envvar-check patch 
>> (included as well).
>> Unrelated to these, I think there might be an issue with 
>> 'testsuite/' - it uses 'LOCALE_JA' variable, but the 
>> variable is not passed using 'testsuite/' in 'TEST_ENVIRONMENT' 
>> like other locales.
>> Perhaps something like:
>> would solve it. will investigate later on.
> Well caught.
> That actually fixes the failure of that test on many systems (at least
> Centos6 and Centos7-based, but not on F24).
> I will amend. Thank you!

Actually not. Amending a bug-fix (albeit test-only) change into a
no-semantic-change diff is not proper. Besides, you found it, so it's
your commit. If you can ACK these (I believe the first is unchanged
from last time), I'm ready to push them:

Attachment: 0001-tests-don-t-let-any-envvar-setting-perturb-tests.patch
Description: Text Data

Attachment: 0002-tests-invalid-mb-seq-UMR-avoid-false-failure.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]