[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: tests: test -i/--inplace with backup suffix option

From: Jim Meyering
Subject: Re: tests: test -i/--inplace with backup suffix option
Date: Wed, 1 Jun 2016 20:41:13 -0700

On Wed, Jun 1, 2016 at 8:38 PM, Jim Meyering <address@hidden> wrote:
> On Tue, May 31, 2016 at 10:26 PM, Assaf Gordon <address@hidden> wrote:
>> Hello,
>>> Instead, I propose the attached patch (intended to be applied before
>>> your test additions), that adds the envvar-check file, as used in grep
>>> and coreutils, along with adjustments
>> Attached improved (and expanded) tests, adjusted to the envvar-check patch 
>> (included as well).
> It's great that you're adding such thorough test coverage.
> I've looked through enough that I feel good about saying "please push".
> Thanks again!

Oh, and please do push them as separate patches.
As long as tests pass at every step along the way (which I presume is
true), separate patches is almost always better.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]