[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 1/2] return status from set_data_mode

From: Hynek Hanke
Subject: [PATCH 1/2] return status from set_data_mode
Date: Sat, 07 Aug 2010 12:42:26 +0200

On 6.8.2010 23:57, Trevor Saunders wrote:
> return the value of self._conn.send_command() in set_data_mode()

Hello Trevor,

thank you for working on this, the error states should not be ignored.
SSML mode should however always succeed in SSIP, unless connection
is broken, requested value is invalid or something like that.

So I think we should not return a value for the error state
but we should simply raise an exception if something fails.

And I think the same goes for the other set_ methods.

Best regards,
Hynek Hanke

reply via email to

[Prev in Thread] Current Thread [Next in Thread]