[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Code review and commits to the official repository

From: Chris Brannon
Subject: Code review and commits to the official repository
Date: Tue, 10 Aug 2010 10:39:56 -0500

Hynek Hanke wrote:
> A piece of code (a patch on the mailing list, a branch
> from a private Git repository etc.) cannot be submitted
> to the repository by the original developer himself,
> but must be first submitted for review. The reviewer
> will push it to the official Git repository.

This sounds good.
How about signed-off-by lines?  Should the reviewer add one before
committing?  I like them, myself, because it is obvious who reviewed
the patch.

> We propose the code reviewers can be (it they like to):
>      Christopher Brannon

Sure, and thank you.

-- Chris

reply via email to

[Prev in Thread] Current Thread [Next in Thread]