[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Code review and commits to the official repository

From: Tomas Cerha
Subject: Code review and commits to the official repository
Date: Wed, 11 Aug 2010 21:12:18 +0200

Dne 11.8.2010 20:24, William Hubbs napsal(a):
> On Wed, Aug 11, 2010 at 03:51:38PM +0200, Tomas Cerha wrote:
>> Dne 10.8.2010 17:39, Chris Brannon napsal(a):
>>> This sounds good.
>>> How about signed-off-by lines?  Should the reviewer add one before
>>> committing?  I like them, myself, because it is obvious who reviewed
>>> the patch.
>> Good point.  I haven't used that before, but it looks good to me.  Maybe
>> the "Reviewed-by" tag would be more appropriate for us, according to:
>> http://gerrit.googlecode.com/svn/documentation/2.0/user-signedoffby.html
> I'm not sure how you do a Reviewed-by tag in git, but Signed-off-by is
> as easy as adding a -s option to "git commit" or "git am".

If someone finds out, I'd be interested to know as well...  Tomas

reply via email to

[Prev in Thread] Current Thread [Next in Thread]