[PATCH 4/7] replace EVoiceType with SPDVoiceType

[Andrei . Kholodnyi]

> So do_set will always fail if the server sends voice=null. In other
> words, it fails when you try to set the synthesis voice. The simple
> solution is seemingly to remove the check for -1.

Hi Chris, it is not my bug :D
please look at this. on the server side we have:

#define ADD_SET_STR_C(name, fconv) \
val = fconv(msg->settings.name); \
if (val != NULL){ \
g_string_append_printf(set_str, #name"=%s\n", val); \
}else{ \
g_string_append_printf(set_str, #name"=NULL\n"); \
} \
g_free(val);

ie if the server can not convert value to string it sends "NULL"
Now what does it mean for the module? ignore this value? or reject this  
value? something else?

for the moment following values are rejected:

punctuation_mode=NULL
spelling_mode=NULL
cap_let_recogn=NULL

but voice=NULL was accepted and converted to NO_VOICE

I do believe we just need to remove
}else{ \
g_string_append_printf(set_str, #name"=NULL\n"); \
} \

what do you think?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: 
<http://lists.freebsoft.org/pipermail/speechd/attachments/20101102/7f31ba89/attachment.htm>