speechd-discuss
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

pull request for Espeak pitch range fork


From: Luke Yelavich
Subject: pull request for Espeak pitch range fork
Date: Fri, 24 Oct 2014 09:45:43 -0400

On Sun, Oct 19, 2014 at 03:30:36PM EDT, Luke Yelavich wrote:
> Whilst I was reviewing and hand-editing your patches, I also noticed one more 
> thing that escaped my notice originally. You define new methods for setting 
> pitch range in src/api/c/libspeechd.h, but you do not provide implementations 
> for these methods in src/api/c/libspeechd.c. At this point I cannot continue 
> with testing your code since your implementation in the C API is incomplete.

Turns out that this was my bad. I haven't yet had much to do with that part of 
the API, so was not aware that those methods are created in some macro 
craziness, so in fact your code is complete.

I will resume looking it over and testing.

My apologies, and thanks.

Luke



reply via email to

[Prev in Thread] Current Thread [Next in Thread]