tiger-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Tiger-devel] [PATCH] missing haveallvars in check_accounts


From: Nicolas François
Subject: [Tiger-devel] [PATCH] missing haveallvars in check_accounts
Date: Tue, 16 Sep 2003 22:35:02 +0200
User-agent: Mutt/1.5.4i

Hello,

Variables HOSTNAME and TESTEXEC could be tested in check_accounts
(haveallvars).

I'm not sure of the other changes:
  + I removed the test for RM. RM is not used directly in
    check_accounts (it uses delete, which will need RM).
    Should initdefs have tests for necessary commands, files or variables?
      RM, WORKDIR, EGREP, AWK, LS, LSLINK, LSGROUP, BASEDIR, SCRIPTDIR,
      TESTEXEC are used in initdefs
    idem for config?
  + I removed the line 'haveallcmds CHECK_CRON || CHECK_CRON='.
    CHECK_CRON is already tested. Was 'CHECK_CRON=' used to empty
    CHECK_CRON, or was something like "check_cron" missing?


Kind Regards,
-- 
Nekral

Attachment: 35_check_accounts_add_haveallvars_test.patch
Description: Text document


reply via email to

[Prev in Thread] Current Thread [Next in Thread]