Re: [Tiger-devel] [PATCH] missing haveallvars in check_accounts

[Javier Fernández-Sanguino Peña]

(Note: I've included now all your patches, thanks a lot Nicolas!)

On Tue, Sep 16, 2003 at 10:35:02PM +0200, Nicolas François wrote:
> Hello,
> 
> Variables HOSTNAME and TESTEXEC could be tested in check_accounts
> (haveallvars).

Done.

> 
> I'm not sure of the other changes:
>   + I removed the test for RM. RM is not used directly in
>     check_accounts (it uses delete, which will need RM).
>     Should initdefs have tests for necessary commands, files or variables?
>       RM, WORKDIR, EGREP, AWK, LS, LSLINK, LSGROUP, BASEDIR, SCRIPTDIR,
>       TESTEXEC are used in initdefs
>     idem for config?

No, the tests should be done in the scripts themselves. Initdefs should 
just have the common functions and config loads the system config file so 
it cannot check for these.


Regards

Javi

pgpABt_bl02cV.pgp
Description: PGP signature