Re: [Tiger-devel] [PATCH] check_accounts: fix check_disabled call

[Javier Fernández-Sanguino Peña]

On Sat, Sep 20, 2003 at 05:14:34AM +0200, Nicolas François wrote:
> Hello,
> 
> I've tried check_accounts. It failed with these warnings:
> /usr/lib/tiger/scripts/check_accounts: eval: line 3: syntax error near 
> unexpected token `adm'
> /usr/lib/tiger/scripts/check_accounts: eval: line 3: `adm|bin|[...])'

As a matter of fact I just needed to fix the call to check_disabled() in 
line 193. Once it is fixed the error does not show up again.

(..)
> 
> I've fixed the call of check_disabled (add the shell argument), and
> changed check_disabled so it use $1 - $4 for its arguments (and doesn't
> read them on input).
> 
I have not added this but I have fixed the call to it below.

> I think the issue is fixed (I don't have any warning now and the report
> seems correct), but am still a little bit confused about the warnings
> (was $user empty on line 263, due to check_disabled reading input of
> check_users?).
> 
It looks to me it was an issue on line 362. When the call to check_disabled 
did not include the 'shell' parameter it did not get defined properly (it's 
value was in fact $user). That's kind of weird, since the 'while read' 
shouldn't have gone through....

Regards

Javi

pgp__kWx3j0g9.pgp
Description: PGP signature