[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Enable adb port in tramp adb

From: Michael Albinus
Subject: Re: Enable adb port in tramp adb
Date: Wed, 14 Jan 2015 16:36:32 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux)

Ashi <address@hidden> writes:

> Hi, Michael,

Hi Zhongwei,

> This update includes following change:
> - Fix the auto completion bug.

Now that your FSF assignment is complete (congratulations!), I did a
more granular review + test of your patch. Some remarks:

- I still would like to call the entry in tramp-methods tramp-default-port.
  We shall not introduce different entries for the same thing, and
  tramp-default-port does exist already.

- I've added traces to tramp-adb-parse-device-names, and now it's
  visible that this is called very often. Not so good with performance
  in mind; maybe we could do something in the future to change it. Call
  it less often, cache the result, whatever.

  I have also changed it to return "host#port" entries. So we could work
  with this syntax internally. By this, I could remove

- I have rewritten tramp-adb-get-host-for-execution (new name is
  tramp-adb-get-device) in order to simplify it. Works for me, but I'm
  not sure whether it is OK for all use cases. Please check!

  It uses now also caching. tramp-adb-search-host-in-devices is not
  needed anymore.

- In tramp-adb-maybe-open-connection I have applied changes resulting
  from the previous ones. I have also removed some checks for devices;
  hopefully I haven't removed too much.

Could you, please, test the updated patch? If it is fine with you, I
would commit it in your name. I would need ChangeLog entries from you.

> Best regards,
> Zhongwei 

Best regards, Michael.

Attachment: txtS16ehsnerZ.txt
Description: Text document

reply via email to

[Prev in Thread] Current Thread [Next in Thread]