[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: push parser
From: |
Bob Rossi |
Subject: |
Re: push parser |
Date: |
Sat, 16 Dec 2006 23:08:34 -0500 |
User-agent: |
Mutt/1.5.12-2006-07-14 |
On Sat, Dec 16, 2006 at 08:43:20PM -0500, Joel E. Denny wrote:
> On Sat, 16 Dec 2006, Paul Eggert wrote:
>
> > "Joel E. Denny" <address@hidden> writes:
> >
> > > + m4_ifset([b4_parse_param], [,]) b4_parse_param)[
> >
> > The patch overall looks fine to me, but one minor thing. In usages
> > like this, it's better to put the empty item inside the conditional.
> > That is:
> >
> > m4_ifset([b4_parse_param], [, b4_parse_param]))[
> >
> > This is the usual style in Bison and it's easier to follow.
>
> I like that better. Thanks. Here's the updated patch, which I committed.
Thanks Joel.
Do you have an open list of items you'd like me to fix?
Thanks,
Bob Rossi
- Re: push parser, (continued)
- Re: push parser, Paul Eggert, 2006/12/15
- Re: push parser, Joel E. Denny, 2006/12/15
- Re: push parser, Paul Eggert, 2006/12/15
- Re: push parser, Joel E. Denny, 2006/12/15
- Message not available
- Message not available
- Re: push parser, Bob Rossi, 2006/12/16
- Re: push parser, Joel E. Denny, 2006/12/16
- Re: push parser, Bob Rossi, 2006/12/16
- Re: push parser, Bob Rossi, 2006/12/17
- Re: push parser, Paul Eggert, 2006/12/16
- Re: push parser, Joel E. Denny, 2006/12/16
- Re: push parser,
Bob Rossi <=
- Re: push parser, Joel E. Denny, 2006/12/18
- Re: push parser, Bob Rossi, 2006/12/18
- Re: push parser, Joel E. Denny, 2006/12/18
- Re: push parser, Bob Rossi, 2006/12/18
- Re: push parser, Paul Eggert, 2006/12/18
- Re: push parser, Joel E. Denny, 2006/12/18
- Re: push parser, Paul Eggert, 2006/12/18
- Re: push parser, Joel E. Denny, 2006/12/18
- Re: push parser, Joel E. Denny, 2006/12/18
- Re: push parser, Joel E. Denny, 2006/12/18