[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#59691: 29.0.60; typescript-ts-mode: any HTML-like elements causes fo
From: |
Theodor Thornhill |
Subject: |
bug#59691: 29.0.60; typescript-ts-mode: any HTML-like elements causes fontification to become invalid and remaining parse-tree to become jsx-expression |
Date: |
Thu, 01 Dec 2022 11:52:00 +0100 |
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Theodor Thornhill <theo@thornhill.no>
>> Cc: casouri@gmail.com, jostein@secure.kjonigsen.net, 59691@debbugs.gnu.org,
>> jostein@kjonigsen.net
>> Date: Thu, 01 Dec 2022 09:12:58 +0100
>>
>> > Looks like some "git merge" snafu? You are in fact reverting a change I
>> > made in NEWS yesterday.
>> >
>>
>> You're right - I think I fixed it now.
>
> Yes, thanks.
>
>> > I don't see a change to auto-mode-alist to turn on each mode for the files
>> > it supports? I thought this was the idea? Or is this because we don't
>> > want
>> > tree-sitter based modes to be turned on by default? In that case, how do
>> > we
>> > explain to users that they should use each mode in the relevant cases?
>>
>> I think there should be
>>
>>
>> ;;;###autoload
>> (add-to-list 'auto-mode-alist '("\\.ts\\'" . typescript-ts-mode))
>>
>> ;;;###autoload
>> (add-to-list 'auto-mode-alist '("\\.tsx\\'" . tsx-ts-mode))
>
> Yes, I missed that, sorry. But the NEWS entry should clearly say that one
> mode is the default for *.ts files, the other for *.tsx files.
No worries :)
Is this patch suitable?
Theo
0001-Add-new-TypeScript-mode-tsx-ts-mode.patch
Description: Text Data
- bug#59691: 29.0.60; typescript-ts-mode: any HTML-like elements causes fontification to become invalid and remaining parse-tree to become jsx-expression, Theodor Thornhill, 2022/12/01
- bug#59691: 29.0.60; typescript-ts-mode: any HTML-like elements causes fontification to become invalid and remaining parse-tree to become jsx-expression, Eli Zaretskii, 2022/12/01
- bug#59691: 29.0.60; typescript-ts-mode: any HTML-like elements causes fontification to become invalid and remaining parse-tree to become jsx-expression, Theodor Thornhill, 2022/12/01
- bug#59691: 29.0.60; typescript-ts-mode: any HTML-like elements causes fontification to become invalid and remaining parse-tree to become jsx-expression, Eli Zaretskii, 2022/12/01
- bug#59691: 29.0.60; typescript-ts-mode: any HTML-like elements causes fontification to become invalid and remaining parse-tree to become jsx-expression,
Theodor Thornhill <=
- bug#59691: 29.0.60; typescript-ts-mode: any HTML-like elements causes fontification to become invalid and remaining parse-tree to become jsx-expression, Eli Zaretskii, 2022/12/01
- bug#59691: 29.0.60; typescript-ts-mode: any HTML-like elements causes fontification to become invalid and remaining parse-tree to become jsx-expression, Yuan Fu, 2022/12/01
- bug#59691: 29.0.60; typescript-ts-mode: any HTML-like elements causes fontification to become invalid and remaining parse-tree to become jsx-expression, Theodor Thornhill, 2022/12/02
- bug#59691: 29.0.60; typescript-ts-mode: any HTML-like elements causes fontification to become invalid and remaining parse-tree to become jsx-expression, Jostein Kjønigsen, 2022/12/02
- bug#59691: 29.0.60; typescript-ts-mode: any HTML-like elements causes fontification to become invalid and remaining parse-tree to become jsx-expression, Theodor Thornhill, 2022/12/02
- bug#59691: 29.0.60; typescript-ts-mode: any HTML-like elements causes fontification to become invalid and remaining parse-tree to become jsx-expression, Eli Zaretskii, 2022/12/03