[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#59691: 29.0.60; typescript-ts-mode: any HTML-like elements causes fo
From: |
Theodor Thornhill |
Subject: |
bug#59691: 29.0.60; typescript-ts-mode: any HTML-like elements causes fontification to become invalid and remaining parse-tree to become jsx-expression |
Date: |
Fri, 02 Dec 2022 21:29:28 +0100 |
Yuan Fu <casouri@gmail.com> writes:
>> On Dec 1, 2022, at 4:10 AM, Eli Zaretskii <eliz@gnu.org> wrote:
>>
>>> From: Theodor Thornhill <theo@thornhill.no>
>>> Cc: casouri@gmail.com, jostein@secure.kjonigsen.net, 59691@debbugs.gnu.org,
>>> jostein@kjonigsen.net
>>> Date: Thu, 01 Dec 2022 11:52:00 +0100
>>>
>>>> Yes, I missed that, sorry. But the NEWS entry should clearly say that one
>>>> mode is the default for *.ts files, the other for *.tsx files.
>>>
>>> No worries :)
>>>
>>> Is this patch suitable?
>>
>> LGTM, thanks.
>>
>> Yuan, if you are okay with this, please install.
>
> Cool. I applied the patch, thanks Theo! I changed
> typescript-ts-mode—base-mode to typescript-ts-base-mode, since I don’t think
> anyone has strong opinions about its naming, and typescript-ts-base-mode is
> more consistent with other tree-sitter base modes.
>
> Yuan
Thanks! I believe this can be closed. What do you think, Jostein?
Theo
- bug#59691: 29.0.60; typescript-ts-mode: any HTML-like elements causes fontification to become invalid and remaining parse-tree to become jsx-expression, Theodor Thornhill, 2022/12/01
- bug#59691: 29.0.60; typescript-ts-mode: any HTML-like elements causes fontification to become invalid and remaining parse-tree to become jsx-expression, Eli Zaretskii, 2022/12/01
- bug#59691: 29.0.60; typescript-ts-mode: any HTML-like elements causes fontification to become invalid and remaining parse-tree to become jsx-expression, Theodor Thornhill, 2022/12/01
- bug#59691: 29.0.60; typescript-ts-mode: any HTML-like elements causes fontification to become invalid and remaining parse-tree to become jsx-expression, Eli Zaretskii, 2022/12/01
- bug#59691: 29.0.60; typescript-ts-mode: any HTML-like elements causes fontification to become invalid and remaining parse-tree to become jsx-expression, Theodor Thornhill, 2022/12/01
- bug#59691: 29.0.60; typescript-ts-mode: any HTML-like elements causes fontification to become invalid and remaining parse-tree to become jsx-expression, Eli Zaretskii, 2022/12/01
- bug#59691: 29.0.60; typescript-ts-mode: any HTML-like elements causes fontification to become invalid and remaining parse-tree to become jsx-expression, Yuan Fu, 2022/12/01
- bug#59691: 29.0.60; typescript-ts-mode: any HTML-like elements causes fontification to become invalid and remaining parse-tree to become jsx-expression,
Theodor Thornhill <=
- bug#59691: 29.0.60; typescript-ts-mode: any HTML-like elements causes fontification to become invalid and remaining parse-tree to become jsx-expression, Jostein Kjønigsen, 2022/12/02
- bug#59691: 29.0.60; typescript-ts-mode: any HTML-like elements causes fontification to become invalid and remaining parse-tree to become jsx-expression, Theodor Thornhill, 2022/12/02
- bug#59691: 29.0.60; typescript-ts-mode: any HTML-like elements causes fontification to become invalid and remaining parse-tree to become jsx-expression, Eli Zaretskii, 2022/12/03