[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#59888: [PATCH] Add 'grep-heading-mode'
From: |
Mattias Engdegård |
Subject: |
bug#59888: [PATCH] Add 'grep-heading-mode' |
Date: |
Thu, 8 Dec 2022 10:57:59 +0100 |
No argument about the idea (good to me) or implementation but minor points
regarding the regexp:
> + (group-n 1 (+? any))
Very much prefer `nonl` or `not-newline` to `any`, which is only there for
compatibility (shouldn't have been included in the first place).
> + (any "\0-:="))
Is the range (ASCII 00..1A) intended here, or should that be a literal hyphen?
If the former, it should probably be made more explicit since that range
includes all sorts of numbers, symbols and control chars and it kind of looks
like it may be a mistake.
- bug#59888: [PATCH] Add 'grep-heading-mode', (continued)
- bug#59888: [PATCH] Add 'grep-heading-mode', Augusto Stoffel, 2022/12/09
- bug#59888: [PATCH] Add 'grep-use-headings', Augusto Stoffel, 2022/12/09
- bug#59888: [PATCH] Add 'grep-use-headings', Eli Zaretskii, 2022/12/09
- bug#59888: [PATCH] Add 'grep-use-headings', Augusto Stoffel, 2022/12/09
- bug#59888: [PATCH] Add 'grep-use-headings', Eli Zaretskii, 2022/12/09
- bug#59888: [PATCH] Add 'grep-use-headings', Augusto Stoffel, 2022/12/10
- bug#59888: [PATCH] Add 'grep-use-headings', Eli Zaretskii, 2022/12/10
- bug#59888: [PATCH] Add 'grep-use-headings', Augusto Stoffel, 2022/12/11
- bug#59888: [PATCH] Add 'grep-use-headings', Gregory Heytings, 2022/12/09
- bug#59888: [PATCH] Add 'grep-use-headings', Juri Linkov, 2022/12/10
bug#59888: [PATCH] Add 'grep-heading-mode',
Mattias Engdegård <=
bug#59888: [PATCH] Add 'grep-heading-mode', Juri Linkov, 2022/12/09