[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#59888: [PATCH] Add 'grep-heading-mode'
From: |
Augusto Stoffel |
Subject: |
bug#59888: [PATCH] Add 'grep-heading-mode' |
Date: |
Thu, 08 Dec 2022 11:28:55 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
On Thu, 8 Dec 2022 at 10:57, Mattias Engdegård wrote:
> No argument about the idea (good to me) or implementation but minor points
> regarding the regexp:
>
>> + (group-n 1 (+? any))
>
> Very much prefer `nonl` or `not-newline` to `any`, which is only there for
> compatibility (shouldn't have been included in the first place).
Hum, not-newline is too long, so this leaves an option between the
slightly deceiving and the quite obscure.
Okay, now I see `any' is not even documented.
>> + (any "\0-:="))
>
> Is the range (ASCII 00..1A) intended here, or should that be a literal hyphen?
> If the former, it should probably be made more explicit since that
> range includes all sorts of numbers, symbols and control chars and it
> kind of looks like it may be a mistake.
The literal hyphen, which prefixes context lines in `grep -C <n>'.
Thanks for the heads up.
- bug#59888: [PATCH] Add 'grep-use-headings', (continued)
- bug#59888: [PATCH] Add 'grep-use-headings', Augusto Stoffel, 2022/12/09
- bug#59888: [PATCH] Add 'grep-use-headings', Eli Zaretskii, 2022/12/09
- bug#59888: [PATCH] Add 'grep-use-headings', Augusto Stoffel, 2022/12/09
- bug#59888: [PATCH] Add 'grep-use-headings', Eli Zaretskii, 2022/12/09
- bug#59888: [PATCH] Add 'grep-use-headings', Augusto Stoffel, 2022/12/10
- bug#59888: [PATCH] Add 'grep-use-headings', Eli Zaretskii, 2022/12/10
- bug#59888: [PATCH] Add 'grep-use-headings', Augusto Stoffel, 2022/12/11
- bug#59888: [PATCH] Add 'grep-use-headings', Gregory Heytings, 2022/12/09
- bug#59888: [PATCH] Add 'grep-use-headings', Juri Linkov, 2022/12/10
bug#59888: [PATCH] Add 'grep-heading-mode', Mattias Engdegård, 2022/12/08
- bug#59888: [PATCH] Add 'grep-heading-mode',
Augusto Stoffel <=
bug#59888: [PATCH] Add 'grep-heading-mode', Juri Linkov, 2022/12/09