[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#59897: 29.0.60; csharp-ts-mode: variable-name fontified as method wh
From: |
Theodor Thornhill |
Subject: |
bug#59897: 29.0.60; csharp-ts-mode: variable-name fontified as method when invoking method with generic type-argument. |
Date: |
Thu, 08 Dec 2022 12:12:17 +0100 |
Jostein Kjønigsen <jostein@secure.kjonigsen.net> writes:
> On 08.12.2022 11:12, Theodor Thornhill wrote:
>> Jostein Kjønigsen <jostein@secure.kjonigsen.net> writes:
>>
>>> When I use the new csharp-ts-mode, method fontification is usually accurate
>>> with only 1 exception which I have
>>> encountered so far:
>>>
>>> When calling methods on objects, and that method accepts a generic
>>> type-argument. You typically see this in
>>> Startup.cs-like files in ASP.Net Core projects:
>>>
>>> services.AddSomeExtensionWithoutTypeArguments();
>>> services.AddSomeExtensionWithTypeArguments<MyType>();
>>>
>>> In the above cases we see that fontification of "services" differs.
>>>
>>> For the first line, services is fontified using
>>> font-lock-variable-name-face (correct), but in the latter case services
>>> is fontified using font-lock-function-name-face (incorrect).
>>>
>>> In both cases I expected services to be fontified using
>>> font-lock-variable-name-face.
>>>
>> Can you test this patch, Jostein, and if you're happy, please install,
>> Yuan :-)
>
> I beat you by 3 minutes, but I'll be a gentleman and test none the less :D
>
> You test mine, and we can see which one we prefer?
Sure! Both seems to work from what I can tell :-) I'll let you be the
judge!
Theo
- bug#59897: 29.0.60; csharp-ts-mode: variable-name fontified as method when invoking method with generic type-argument., Jostein Kjønigsen, 2022/12/08
- bug#59897: 29.0.60; csharp-ts-mode: variable-name fontified as method when invoking method with generic type-argument., Theodor Thornhill, 2022/12/08
- bug#59897: 29.0.60; csharp-ts-mode: variable-name fontified as method when invoking method with generic type-argument., Jostein Kjønigsen, 2022/12/08
- bug#59897: 29.0.60; csharp-ts-mode: variable-name fontified as method when invoking method with generic type-argument.,
Theodor Thornhill <=
- bug#59897: 29.0.60; csharp-ts-mode: variable-name fontified as method when invoking method with generic type-argument., Jostein Kjønigsen, 2022/12/08
- bug#59897: 29.0.60; csharp-ts-mode: variable-name fontified as method when invoking method with generic type-argument., Jostein Kjønigsen, 2022/12/09
- bug#59897: 29.0.60; csharp-ts-mode: variable-name fontified as method when invoking method with generic type-argument., Theodor Thornhill, 2022/12/09
- bug#59897: 29.0.60; csharp-ts-mode: variable-name fontified as method when invoking method with generic type-argument., Jostein Kjønigsen, 2022/12/12
- bug#59897: 29.0.60; csharp-ts-mode: variable-name fontified as method when invoking method with generic type-argument., Yuan Fu, 2022/12/12
- bug#59897: 29.0.60; csharp-ts-mode: variable-name fontified as method when invoking method with generic type-argument., Jostein Kjønigsen, 2022/12/14
- bug#59897: 29.0.60; csharp-ts-mode: variable-name fontified as method when invoking method with generic type-argument., Yuan Fu, 2022/12/14
- bug#59897: 29.0.60; csharp-ts-mode: variable-name fontified as method when invoking method with generic type-argument., Jostein Kjønigsen, 2022/12/14
- bug#59897: 29.0.60; csharp-ts-mode: variable-name fontified as method when invoking method with generic type-argument., Yuan Fu, 2022/12/14
bug#59897: 29.0.60; csharp-ts-mode: variable-name fontified as method when invoking method with generic type-argument., Yuan Fu, 2022/12/09