bug#60893: 30.0.50; ad-deactive has broken interactive TAB completion

[Dima Kogan]

You can't reproduce? How odd. I'm using an emacs-snapshot Debian package
from emacs.secretsauce.net:

  dima@shorty:~$ dpkg -l emacs-snapshot-el
  Desired=Unknown/Install/Remove/Purge/Hold
  | Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
  |/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
  ||/ Name              Version                                     
Architecture Description
  
+++-=================-===========================================-============-=================================
  ii  emacs-snapshot-el 2:20230116+emacs-28.2-163642-g77659bd4634-1 all         
 GNU Emacs LISP (.el) files

So I'm here:

  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=77659bd

Built yesterday. The backtrace looks like this:

  Debugger entered--Lisp error: (wrong-type-argument listp "open-line")
    #f(compiled-function (function) #<bytecode -0x477dabbd668b065>)("open-line")
    completion-basic-try-completion("" ("open-line") #f(compiled-function 
(function) #<bytecode -0x477dabbd668b065>) 0)
    #f(compiled-function (style) #<bytecode 0xe13106688cb6919>)(basic)
    completion--some(#f(compiled-function (style) #<bytecode 
0xe13106688cb6919>) (basic partial-completion emacs22))
    completion--nth-completion(1 "" ("open-line") #f(compiled-function 
(function) #<bytecode -0x477dabbd668b065>) 0 (metadata))
    completion-try-completion("" ("open-line") #f(compiled-function (function) 
#<bytecode -0x477dabbd668b065>) 0 (metadata))
    completion--do-completion(43 43)
    completion--in-region-1(43 43)
    #f(compiled-function (start end collection predicate) #<bytecode 
0x6e440600d522b49>)(43 43 ("open-line") #f(compiled-function (function) 
#<bytecode -0x477dabbd668b065>))
    apply(#f(compiled-function (start end collection predicate) #<bytecode 
0x6e440600d522b49>) (43 43 ("open-line") #f(compiled-function (function) 
#<bytecode -0x477dabbd668b065>)))
    #f(compiled-function (funs global args) #<bytecode -0xf51d361c9e65a2>)(nil 
nil (43 43 ("open-line") #f(compiled-function (function) #<bytecode 
-0x477dabbd668b065>)))
    completion--in-region(43 43 ("open-line") #f(compiled-function (function) 
#<bytecode -0x477dabbd668b065>))
    completion-in-region(43 43 ("open-line") #f(compiled-function (function) 
#<bytecode -0x477dabbd668b065>))
    minibuffer-complete()
    funcall-interactively(minibuffer-complete)
    command-execute(minibuffer-complete)
    completing-read-default("Deactivate advice of (default open-line): " 
("open-line") #f(compiled-function (function) #<bytecode -0x477dabbd668b065>) t 
nil nil nil nil)
    completing-read("Deactivate advice of (default open-line): " ("open-line") 
#f(compiled-function (function) #<bytecode -0x477dabbd668b065>) t)
    ad-read-advised-function("Deactivate advice of" ad-is-active)
    byte-code("\300\301\302\"C\207" [ad-read-advised-function "Deactivate 
advice of" ad-is-active] 3)
    command-execute(ad-deactivate record)
    execute-extended-command(nil "ad-deactivate" "ad-deac")
    funcall-interactively(execute-extended-command nil "ad-deactivate" 
"ad-deac")
    command-execute(execute-extended-command)

I haven't tried to fix it myself. Will do that eventually if nobody
beats me to it.

Thanks!