[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#60893: 30.0.50; ad-deactive has broken interactive TAB completion
From: |
Michael Heerdegen |
Subject: |
bug#60893: 30.0.50; ad-deactive has broken interactive TAB completion |
Date: |
Wed, 18 Jan 2023 12:34:51 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Dima Kogan <dima@secretsauce.net> writes:
> 4. M-x ad-deactivate TAB
>
> It should try to complete to a list of existing advised functions.
> Intead it throws an error:
>
> completion--some: Wrong type argument: listp, "open-line"
Looks like a regression introduced by
77c3c464a16 * lisp/emacs-lisp/advice.el (ad-advised-functions): Make it a plain
list
Stefan Monnier <monnier@iro.umontreal.ca> 2018-09-17
Does this fix your problem?
From 5e0980aac23cfa9e5417f07b8853405ad10ee228 Mon Sep 17 00:00:00 2001
From: Michael Heerdegen <michael_heerdegen@web.de>
Date: Wed, 18 Jan 2023 12:32:05 +0100
Subject: [PATCH] WIP: Fix #60893
---
lisp/emacs-lisp/advice.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/emacs-lisp/advice.el b/lisp/emacs-lisp/advice.el
index 080a6d84498..56f0ae2212c 100644
--- a/lisp/emacs-lisp/advice.el
+++ b/lisp/emacs-lisp/advice.el
@@ -1850,7 +1850,7 @@ ad-read-advised-function
ad-advised-functions
(if predicate
(lambda (function)
- (funcall predicate (intern (car function)))))
+ (funcall predicate (intern function))))
t)))
(if (equal function "")
(if (ad-is-advised default)
--
2.30.2
Thanks,
Michael.
- bug#60893: 30.0.50; ad-deactive has broken interactive TAB completion, Dima Kogan, 2023/01/17
- bug#60893: 30.0.50; ad-deactive has broken interactive TAB completion, Ruijie Yu, 2023/01/18
- bug#60893: 30.0.50; ad-deactive has broken interactive TAB completion,
Michael Heerdegen <=
- bug#60893: 30.0.50; ad-deactive has broken interactive TAB completion, Dima Kogan, 2023/01/19
- bug#60893: 30.0.50; ad-deactive has broken interactive TAB completion, Michael Heerdegen, 2023/01/19
- bug#60893: 30.0.50; ad-deactive has broken interactive TAB completion, Howard Melman, 2023/01/19
- bug#60893: 30.0.50; ad-deactive has broken interactive TAB completion, Michael Heerdegen, 2023/01/19
- bug#60893: 30.0.50; ad-deactive has broken interactive TAB completion, Eli Zaretskii, 2023/01/20
- bug#60893: 30.0.50; ad-deactive has broken interactive TAB completion, Michael Heerdegen, 2023/01/20
- bug#60893: 30.0.50; ad-deactive has broken interactive TAB completion, Eli Zaretskii, 2023/01/20