[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] rewrite int foo[2*X-1] to verify(X) or to int foo[X?1:-1]
From: |
Bruno Haible |
Subject: |
Re: [PATCH] rewrite int foo[2*X-1] to verify(X) or to int foo[X?1:-1] |
Date: |
Sun, 10 Oct 2010 23:27:40 +0200 |
User-agent: |
KMail/1.9.9 |
Hi Paul,
> * lib/float+.h (verify_sizeof_flt, verify_sizeof_dbl):
> (verify_sizeof_ldbl): Rewrite 2*X-1 to X?1:-1.
> * lib/malloca.c: Include "verify.h".
> (verify1): Remove, replacing with a verify call.
> * lib/relocwrapper.c (verify1): Likewise.
> * modules/malloca (Depends-on): Add 'verify'.
> * modules/relocatable-prog-wrapper (Depends-on): Add 'verify'.
Fine with me.
> * lib/vasnprintf.c (mp_limb_verify, mp_twolimb_verify, TCHAR_T_verify):
> Likewise.
> * modules/vasnprintf (Depends-on): Add 'verify'.
Fine, except that it's incomplete: modules/vasnprintf is not the only
module affected:
$ ./gnulib-tool --find lib/vasnprintf.c
unistdio/u16-u16-vasnprintf
unistdio/u16-vasnprintf
unistdio/u32-u32-vasnprintf
unistdio/u32-vasnprintf
unistdio/u8-u8-vasnprintf
unistdio/u8-vasnprintf
unistdio/ulc-vasnprintf
vasnprintf
You need to add 'verify' as a dependency of each of these modules.
vasnprintf.c is also shared with libintl in gettext; I'll update gettext
after you did the commit.
Bruno
- Re: [PATCH] time: enforce recent POSIX ruling that time_t is integral, (continued)
- Re: [PATCH] time: enforce recent POSIX ruling that time_t is integral, Bruno Haible, 2010/10/10
- Re: [PATCH] time: enforce recent POSIX ruling that time_t is integral, Paul Eggert, 2010/10/10
- [PATCH] Fix mismatched parens in previous commit, Gary V. Vaughan, 2010/10/11
- Re: [PATCH] Fix mismatched parens in previous commit, Jim Meyering, 2010/10/11
- Re: [PATCH] Fix mismatched parens in previous commit, Gary V. Vaughan, 2010/10/11
- Re: [PATCH] Fix mismatched parens in previous commit, Paul Eggert, 2010/10/11
- [PATCH] rewrite int foo[2*X-1] to verify(X) or to int foo[X?1:-1], Paul Eggert, 2010/10/10
- Re: [PATCH] rewrite int foo[2*X-1] to verify(X) or to int foo[X?1:-1],
Bruno Haible <=
- Re: [PATCH] rewrite int foo[2*X-1] to verify(X) or to int foo[X?1:-1], Paul Eggert, 2010/10/10