[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Fix mismatched parens in previous commit
From: |
Paul Eggert |
Subject: |
Re: [PATCH] Fix mismatched parens in previous commit |
Date: |
Mon, 11 Oct 2010 10:55:12 -0700 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.12) Gecko/20100915 Thunderbird/3.0.8 |
On 10/11/10 01:05, Gary V. Vaughan wrote:
> Pushed as an obvious fix to rebalance parentheses.
Thanks, and sorry about that. I didn't catch it because coreutils doesn't
use that .h file. I originally messed up the parentheses partly because
the code was using a non-GNU indenting style:
((FOO
& BAR) == 0)
and I didn't notice the "== 0".
The code should use this style to lessen confusion:
((FOO
& BAR)
== 0)
so I pushed this further patch.
>From 4615288b60c104efbb98a8165f13263f6ef46a3d Mon Sep 17 00:00:00 2001
From: Paul Eggert <address@hidden>
Date: Mon, 11 Oct 2010 10:49:52 -0700
Subject: [PATCH] Indentation.
* lib/spawn.in.h (verify_POSIX_SPAWN_USEVFORK_no_overlap): Indent
higher-level operators more to the left.
---
ChangeLog | 6 ++++++
lib/spawn.in.h | 3 ++-
2 files changed, 8 insertions(+), 1 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 22a22df..60c0d76 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2010-10-11 Paul Eggert <address@hidden>
+
+ Indentation.
+ * lib/spawn.in.h (verify_POSIX_SPAWN_USEVFORK_no_overlap): Indent
+ higher-level operators more to the left.
+
2010-10-11 Jim Meyering <address@hidden>
test-futimens: avoid unwarranted test failure on Solaris 5.11
diff --git a/lib/spawn.in.h b/lib/spawn.in.h
index 39d6507..26c3c10 100644
--- a/lib/spawn.in.h
+++ b/lib/spawn.in.h
@@ -150,7 +150,8 @@ typedef int verify_POSIX_SPAWN_USEVFORK_no_overlap
[(((POSIX_SPAWN_RESETIDS | POSIX_SPAWN_SETPGROUP
| POSIX_SPAWN_SETSIGDEF | POSIX_SPAWN_SETSIGMASK
| POSIX_SPAWN_SETSCHEDPARAM | POSIX_SPAWN_SETSCHEDULER)
- & POSIX_SPAWN_USEVFORK) == 0)
+ & POSIX_SPAWN_USEVFORK)
+ == 0)
? 1 : -1];
--
1.7.2
- Re: [PATCH] time: enforce recent POSIX ruling that time_t is integral, (continued)
- Re: [PATCH] time: enforce recent POSIX ruling that time_t is integral, Bruno Haible, 2010/10/10
- Re: [PATCH] time: enforce recent POSIX ruling that time_t is integral, Paul Eggert, 2010/10/10
- Re: [PATCH] time: enforce recent POSIX ruling that time_t is integral, Paul Eggert, 2010/10/10
- Re: [PATCH] time: enforce recent POSIX ruling that time_t is integral, Bruno Haible, 2010/10/10
- Re: [PATCH] time: enforce recent POSIX ruling that time_t is integral, Paul Eggert, 2010/10/10
- Re: [PATCH] time: enforce recent POSIX ruling that time_t is integral, Bruno Haible, 2010/10/10
- Re: [PATCH] time: enforce recent POSIX ruling that time_t is integral, Paul Eggert, 2010/10/10
- [PATCH] Fix mismatched parens in previous commit, Gary V. Vaughan, 2010/10/11
- Re: [PATCH] Fix mismatched parens in previous commit, Jim Meyering, 2010/10/11
- Re: [PATCH] Fix mismatched parens in previous commit, Gary V. Vaughan, 2010/10/11
- Re: [PATCH] Fix mismatched parens in previous commit,
Paul Eggert <=
- [PATCH] rewrite int foo[2*X-1] to verify(X) or to int foo[X?1:-1], Paul Eggert, 2010/10/10
- Re: [PATCH] rewrite int foo[2*X-1] to verify(X) or to int foo[X?1:-1], Bruno Haible, 2010/10/10
- Re: [PATCH] rewrite int foo[2*X-1] to verify(X) or to int foo[X?1:-1], Paul Eggert, 2010/10/10