Re: [PATCH] tests: provide an option to relax the need for gdb

[Bernhard Voelker]

On 06/21/2018 06:07 PM, Pádraig Brady wrote:
> On 20/06/18 23:18, Bernhard Voelker wrote:
>> BTW: setting USE_GDB=0 unveils:
>>
>>   ./tests/rm/r-root.sh: line 222: test: =: unary operator expected
>>
>> The variable 'fail' should be initialized:
>>
>>   test $fail = 1 && { cat out; cat err; Exit $fail; }
>>
>> ... *BUT* it seems that we have more cases like that:
>>
>>   $ grep -F 'unary operator expected' tests/*/*.log | sort -u | wc -l
>>   15
>>
>> Maybe we should initialize 'fail' in a central place?
> 
> Hrm maybe. We should at least s/\$fail/"$fail"/.

Currently, the use of `test $fail ...` vs. `test "$fail" ...` is 50:50.
IMO it's easier and safer to initialize fail=0 - the attached does it.

Have a nice day,
Berny

0001-tests-initialize-fail-0-to-avoid-unary-operator-expe.patch
Description: Text Data