[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tests: provide an option to relax the need for gdb
|
From: |
Bernhard Voelker |
|
Subject: |
Re: [PATCH] tests: provide an option to relax the need for gdb |
|
Date: |
Sat, 23 Jun 2018 22:42:04 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 06/22/2018 07:13 PM, Pádraig Brady wrote:
> On 21/06/18 15:32, Bernhard Voelker wrote:
>> Currently, the use of `test $fail ...` vs. `test "$fail" ...` is 50:50.
>> IMO it's easier and safer to initialize fail=0 - the attached does it.
>
> +1
> Also thanks for investigating where the fail=0 was removed.
Thanks for the review - pushed with that note at:
https://git.sv.gnu.org/cgit/coreutils.git/commit/?id=5fb8eb091
Have a nice day,
Berny