Re: Changes in calendar/time-date.el

[Lute Kamstra]

Reiner Steib <address@hidden> writes:

>> I removed (require 'parse-time) from time-date because it uses just
>> parse-time-string, which is autoloaded.  Do I understand correctly my
>> change uncovered some bugs in nnimap.el, nnultimate.el and pop3.el?  I
>> already noticed (and fixed) this for message.el.  
>
> Wouldn't it be better to put (require 'parse-time) at the beginning of
> the file instead of inside `message-make-date'?

message-make-date is the only function in message.el that uses
parse-time, so it's best to put the require there.  If you change
message-make-date so that it no longer uses parse-time, you will
probably notice the require and remove it.  Had you put require at the
beginning of the file, you would most likely forget this.  Putting a
require at the beginning of a file is useful if the file uses a
particular feature a lot.

Lute.