Re: your vc-dir-mode-map change

[Sam Steingold]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Dan Nicolaescu wrote:
|
| Can you please undo your vc-dir-mode-map change?
|
| "d" would be more useful if it followed what PCL-CVS does, provide
| better diff functionality.

would "r" be OK with you?
PCL-CVS binds that to remove.

| Deletion is not a very frequent action, so it does not seem like a good
| idea to waste an easily accessible key for it.  Also it's better to make
| it harder to delete files, so that users don't do it accidentally.
| It doesn't seem such a big imposition to force the use of a menu or
| M-x vc-delete-file when trying to remove files.

There is no menu item.
I find file deletion to be a fairly common operation.
Accidental deletion of a VC file can be easily undone (as opposed to
deletion of non-VC files, and there _is_ a dired binding for deletion)

| More, vc-delete-file does not have any key binding by default, and we
| haven't gotten any complaints about this...

consider my patch to be such a complaint :-)

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFIGMInPp1Qsf2qnMcRAh1fAKCP89wqjeX4/J2PUXb1790l5pa8tgCdGCKY
FzV+tFYRz26avSj/5lvOdtI=
=tKs+
-----END PGP SIGNATURE-----