[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: your vc-dir-mode-map change
From: |
Dan Nicolaescu |
Subject: |
Re: your vc-dir-mode-map change |
Date: |
Wed, 30 Apr 2008 13:26:57 -0700 |
Sam Steingold <address@hidden> writes:
> Dan Nicolaescu wrote:
> |
> | Can you please undo your vc-dir-mode-map change?
> |
> | "d" would be more useful if it followed what PCL-CVS does, provide
> | better diff functionality.
>
> would "r" be OK with you?
I'd rather keep that one for "rename".
> | Deletion is not a very frequent action, so it does not seem like a good
> | idea to waste an easily accessible key for it. Also it's better to make
> | it harder to delete files, so that users don't do it accidentally.
> | It doesn't seem such a big imposition to force the use of a menu or
> | M-x vc-delete-file when trying to remove files.
>
> There is no menu item.
It should be there first.
> I find file deletion to be a fairly common operation.
That is not the same thing as deleting files from the VC system, which
is not that common.
> | More, vc-delete-file does not have any key binding by default, and we
> | haven't gotten any complaints about this...
>
> consider my patch to be such a complaint :-)
Well, VC has been around for many years, so this does not count much.
We can reconsider this when there's a key binding in the C-x v keymap.