Re: [Emacs-diffs] xwidget 9fe732a 2/2: Better changelog for xwidgets

[Paul Eggert]

On 02/09/2015 03:56 AM, address@hidden wrote:
> --- a/src/coding.c
> +++ b/src/coding.c
> @@ -5985,7 +5985,7 @@ bool
>   raw_text_coding_system_p (struct coding_system *coding)
>   {
>     return (coding->decoder == decode_coding_raw_text
> -         && coding->encoder == encode_coding_raw_text) ? true : false;
> +         && coding->encoder == encode_coding_raw_text);
>   }

Generally speaking, if EXPR is a boolean expression, it's simpler and 
clearer to write 'EXPR' than to write 'EXPR ? true : false'. Also, it 
makes for clearer indenting in this case.

> And these:
> -  next_element_from_stretch
> +  next_element_from_stretch,
>   #ifdef HAVE_XWIDGETS
> -  ,next_element_from_xwidget
> +  next_element_from_xwidget,
>
> is it really correct to move the coma out of the ifdef?

Yes, in C99, which Emacs is now assuming.