[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] pcase.el: Add type pattern

From: Eric Abrahamsen
Subject: Re: [PATCH] pcase.el: Add type pattern
Date: Mon, 09 Mar 2020 11:45:40 -0700
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

Adam Porter <address@hidden> writes:

> Hi,
> It seemed like an obvious and useful improvement to add a "type" pattern
> to pcase, so I prepared this patch.  I wondered if checking for
> predicates like this was a good way to do so, and I saw that the
> cl-typep inliner does basically this, so it seems reasonable.

One thing that's nice about cl-typep is that it will correctly identify
instances of subclasses, which can be nice. Dunno how difficult it might
be to work that in there, but it's something to consider. Either way
this is a nice addition.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]