[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Failing to GC killed buffers considered harmful

From: Eli Zaretskii
Subject: Re: Failing to GC killed buffers considered harmful
Date: Mon, 30 Mar 2020 21:51:48 +0300

> From: Stefan Monnier <address@hidden>
> Cc: Eli Zaretskii <address@hidden>,  Daniel Colascione <address@hidden>,
>   address@hidden
> Date: Mon, 30 Mar 2020 14:32:30 -0400
> > FWIW, maybe we should get rid of all_buffers.
> > AFAICT the only reason we need it is to unmark the buffers during the
> > sweep phase, and we could allocate buffers like any other
> > pseudovector instead.
> The patch below seems to work.
> The only worrisome part I think is that `live_buffer_holding` allowed
> pointers into buffer objects, whereas `live_vector_p` only treats
> pointers to the beginning of the object as a valid reference.
> Not sure why buffers would be more likely to have valid pointers into
> them (and can't remember discussions about that either), so I assume the
> difference was not important (it just happened to be easier to support
> that for buffers).
> Any objection?

What are the advantages?  The original problem is solved, and
everybody agreed that having a dead buffer in the pdumped area is
nothing we should bother about.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]