[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Failing to GC killed buffers considered harmful

From: Stefan Monnier
Subject: Re: Failing to GC killed buffers considered harmful
Date: Mon, 30 Mar 2020 15:40:31 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

>> > FWIW, maybe we should get rid of all_buffers.
>> > AFAICT the only reason we need it is to unmark the buffers during the
>> > sweep phase, and we could allocate buffers like any other
>> > pseudovector instead.
>> The patch below seems to work.
>> The only worrisome part I think is that `live_buffer_holding` allowed
>> pointers into buffer objects, whereas `live_vector_p` only treats
>> pointers to the beginning of the object as a valid reference.
>> Not sure why buffers would be more likely to have valid pointers into
>> them (and can't remember discussions about that either), so I assume the
>> difference was not important (it just happened to be easier to support
>> that for buffers).
>> Any objection?
> What are the advantages?

Simpler code.

> The original problem is solved, and everybody agreed that having
> a dead buffer in the pdumped area is nothing we should bother about.

Indeed, my patch doesn't have anything to do with the original problem,
except that it made me realize this part of the code was not needed
any more.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]