[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: extraclean and admin/grammars [was Re: Git master head build failure
From: |
Stefan Monnier |
Subject: |
Re: extraclean and admin/grammars [was Re: Git master head build failure?] |
Date: |
Thu, 01 Apr 2021 16:13:24 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
>> E.g. a first step could be to move `grammar-wy.el` to `grm-wy-boot.el` like
>> we
>> do with `ldefs-boot.el` (see patch below) to break the
>> circular dependency.
>
> What patch?
What do you mean "what patch"? *The* patch, of course.
Stefan
diff --git a/.gitignore b/.gitignore
index b653ef215b..9fe8ecb594 100644
--- a/.gitignore
+++ b/.gitignore
@@ -88,6 +88,7 @@ lisp/cedet/semantic/wisent/javat-wy.el
lisp/cedet/semantic/wisent/js-wy.el
lisp/cedet/semantic/wisent/python-wy.el
lisp/cedet/srecode/srt-wy.el
+lisp/cedet/semantic/grammar-wy.el
lisp/eshell/esh-groups.el
lisp/finder-inf.el
lisp/leim/ja-dic/
diff --git a/admin/grammars/Makefile.in b/admin/grammars/Makefile.in
index aa09d9edf9..800e31762d 100644
--- a/admin/grammars/Makefile.in
+++ b/admin/grammars/Makefile.in
@@ -48,14 +48,11 @@ BOVINE =
${bovinedir}/make-by.el \
${bovinedir}/scm-by.el
-## FIXME Should include this one too:
-## ${cedetdir}/semantic/grammar-wy.el
-## but semantic/grammar.el (which is what we use to generate grammar-wy.el)
-## requires it!
-WISENT = \
- ${wisentdir}/javat-wy.el \
- ${wisentdir}/js-wy.el \
- ${wisentdir}/python-wy.el \
+WISENT = \
+ ${cedetdir}/semantic/grammar-wy.el \
+ ${wisentdir}/javat-wy.el \
+ ${wisentdir}/js-wy.el \
+ ${wisentdir}/python-wy.el \
${cedetdir}/srecode/srt-wy.el
ALL = ${BOVINE} ${WISENT}
diff --git a/lisp/cedet/semantic/grammar.el b/lisp/cedet/semantic/grammar.el
index dba289fdd7..782327e617 100644
--- a/lisp/cedet/semantic/grammar.el
+++ b/lisp/cedet/semantic/grammar.el
@@ -31,7 +31,12 @@
(require 'semantic/format)
;; FIXME this is a generated file, but we need to load this file to
;; generate it!
-(require 'semantic/grammar-wy)
+;; We need `semantic/grammar-wy.el' but we're also needed to generate
+;; that file from `grammar.wy', so to break the dependency, we keep
+;; a bootstrap copy of `grammar-wy.el' in `grm-wy-boot.el'.
+(eval-and-compile
+ (unless (require 'semantic/grammar-wy nil t)
+ (load "semantic/grm-wy-boot")))
(require 'semantic/idle)
(require 'help-fns)
(require 'semantic/analyze)
diff --git a/lisp/cedet/semantic/grammar-wy.el
b/lisp/cedet/semantic/grm-wy-boot.el
similarity index 100%
rename from lisp/cedet/semantic/grammar-wy.el
rename to lisp/cedet/semantic/grm-wy-boot.el
- Re: extraclean and admin/grammars [was Re: Git master head build failure?], (continued)
- Re: extraclean and admin/grammars [was Re: Git master head build failure?], Eli Zaretskii, 2021/04/02
- Re: extraclean and admin/grammars [was Re: Git master head build failure?], Lars Ingebrigtsen, 2021/04/03
- Re: extraclean and admin/grammars [was Re: Git master head build failure?], Eli Zaretskii, 2021/04/03
- Re: extraclean and admin/grammars [was Re: Git master head build failure?], chad, 2021/04/03
- Re: extraclean and admin/grammars [was Re: Git master head build failure?], Eli Zaretskii, 2021/04/04
- Re: extraclean and admin/grammars [was Re: Git master head build failure?], Tim Cross, 2021/04/03
- Re: extraclean and admin/grammars [was Re: Git master head build failure?], Eli Zaretskii, 2021/04/04
- Re: extraclean and admin/grammars [was Re: Git master head build failure?], Lars Ingebrigtsen, 2021/04/04
- Re: extraclean and admin/grammars [was Re: Git master head build failure?], Stefan Monnier, 2021/04/01
- Re: extraclean and admin/grammars [was Re: Git master head build failure?], Eli Zaretskii, 2021/04/01
- Re: extraclean and admin/grammars [was Re: Git master head build failure?],
Stefan Monnier <=
- Re: extraclean and admin/grammars [was Re: Git master head build failure?], Eli Zaretskii, 2021/04/03
- Re: extraclean and admin/grammars [was Re: Git master head build failure?], Stefan Monnier, 2021/04/12
- Re: extraclean and admin/grammars [was Re: Git master head build failure?], Eli Zaretskii, 2021/04/13
- Re: extraclean and admin/grammars [was Re: Git master head build failure?], Eli Zaretskii, 2021/04/13
- Re: extraclean and admin/grammars [was Re: Git master head build failure?], Stefan Monnier, 2021/04/13
- Re: extraclean and admin/grammars [was Re: Git master head build failure?], Stefan Monnier, 2021/04/13
- Re: extraclean and admin/grammars [was Re: Git master head build failure?], Eli Zaretskii, 2021/04/13
- Re: extraclean and admin/grammars [was Re: Git master head build failure?], Eli Zaretskii, 2021/04/01
- Re: extraclean and admin/grammars [was Re: Git master head build failure?], Glenn Morris, 2021/04/04
- Re: extraclean and admin/grammars [was Re: Git master head build failure?], Eli Zaretskii, 2021/04/04